From 42d811f253c65055a059364ab1be8625f9f9facd Mon Sep 17 00:00:00 2001
From: joni <johnfshaughnessy@gmail.com>
Date: Tue, 29 May 2018 14:31:21 -0700
Subject: [PATCH] lint
---
src/components/look-on-mobile.js | 3 +--
src/hub.js | 3 ++-
src/utils/mouse-events-handler.js | 5 +++--
src/utils/touch-events-handler.js | 1 -
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/components/look-on-mobile.js b/src/components/look-on-mobile.js
index 4c068669b..e8047c92f 100644
--- a/src/components/look-on-mobile.js
+++ b/src/components/look-on-mobile.js
@@ -1,5 +1,4 @@
const PolyfillControls = AFRAME.utils.device.PolyfillControls;
-const PI_4 = Math.PI / 4;
const TWOPI = Math.PI * 2;
const abs = Math.abs;
@@ -64,7 +63,7 @@ AFRAME.registerComponent("look-on-mobile", {
this.cameraController = cameraController;
},
- tick(t, dt) {
+ tick() {
if (!this.data.enabled) return;
const scene = this.el.sceneEl;
if (scene.is("vr-mode") && scene.checkHeadsetConnected()) return; // TODO: Why would this be ticking if we're in vr-mode?
diff --git a/src/hub.js b/src/hub.js
index 23cfc97b1..e92f94f05 100644
--- a/src/hub.js
+++ b/src/hub.js
@@ -252,8 +252,9 @@ const onReady = async () => {
cursorEl.addEventListener("componentinitialized", registerCursor);
}
} else {
- window.APP.touchEventsHandler = new TouchEventsHandler(); // TODO: Do not create TouchEventsHandler unless on mobile
+ window.APP.touchEventsHandler = new TouchEventsHandler();
window.APP.mouseEventsHandler = new MouseEventsHandler();
+ window.APP.gearvrMouseEventsHandler = new GearVRMouseEventsHandler(); // TODO: Use when gearvr is detected
const camera = document.querySelector("#player-camera");
const registerCameraController = e => {
diff --git a/src/utils/mouse-events-handler.js b/src/utils/mouse-events-handler.js
index 359098214..52147c86c 100644
--- a/src/utils/mouse-events-handler.js
+++ b/src/utils/mouse-events-handler.js
@@ -114,6 +114,7 @@ export class MouseEventsHandler {
}
}
+//TODO: Finish gearvr mouse events handler
export class GearVRMouseEventsHandler {
constructor() {
this.cursor = null;
@@ -152,7 +153,7 @@ export class GearVRMouseEventsHandler {
document.addEventListener("mouseup", this.onMouseUp);
}
- onMouseDown(e) {
+ onMouseDown() {
this.isMouseDownHandledByCursor = this.cursor.startInteraction();
if (this.isMouseDownHandledByCursor) {
return;
@@ -162,7 +163,7 @@ export class GearVRMouseEventsHandler {
this.isMouseDownHandledByGazeTeleporter = true;
}
- onMouseUp(e) {
+ onMouseUp() {
if (this.isMouseDownHandledByCursor) {
this.cursor.endInteraction();
this.isMouseDownHandledByCursor = false;
diff --git a/src/utils/touch-events-handler.js b/src/utils/touch-events-handler.js
index 24f58c5d8..2f9f4cb75 100644
--- a/src/utils/touch-events-handler.js
+++ b/src/utils/touch-events-handler.js
@@ -1,7 +1,6 @@
const VIRTUAL_JOYSTICK_HEIGHT = 0.8;
const HORIZONTAL_LOOK_SPEED = 0.35;
const VERTICAL_LOOK_SPEED = 0.18;
-const PI_4 = Math.PI / 4;
//TODO: Oculus Touch controls emit touch events (wat), so we have to filter those out.
export default class TouchEventsHandler {
--
GitLab