From 4986879f1ca97274c2ebc881b5e930a2477dee18 Mon Sep 17 00:00:00 2001
From: Robert Long <robert@robertlong.me>
Date: Tue, 1 May 2018 17:41:31 -0700
Subject: [PATCH] Clean up logs. Fix warning messages and remove unessesary
console.logs.
---
src/App.js | 1 -
src/components/bone-mute-state-indicator.js | 1 -
src/components/controls-shape-offset.js | 2 +-
src/components/hand-controls2.js | 3 +--
src/components/hide-when-quality.js | 1 -
src/react-components/avatar-selector.js | 4 ++--
6 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/src/App.js b/src/App.js
index b814e080d..1f425e82d 100644
--- a/src/App.js
+++ b/src/App.js
@@ -15,7 +15,6 @@ export class App {
this.quality = quality;
if (this.scene) {
- console.log("quality-changed", quality);
this.scene.dispatchEvent(new CustomEvent("quality-changed", { detail: quality }));
}
diff --git a/src/components/bone-mute-state-indicator.js b/src/components/bone-mute-state-indicator.js
index 2d79b3f9c..92a2590e2 100644
--- a/src/components/bone-mute-state-indicator.js
+++ b/src/components/bone-mute-state-indicator.js
@@ -14,7 +14,6 @@ AFRAME.registerComponent("bone-mute-state-indicator", {
this.el.addEventListener("model-loaded", () => {
this.unmutedBone = this.el.object3D.getObjectByName(this.data.unmutedBoneName);
this.mutedBone = this.el.object3D.getObjectByName(this.data.mutedBoneName);
- console.log(this.unmutedBone, this.mutedBone);
this.modelLoaded = true;
this.updateMuteState();
diff --git a/src/components/controls-shape-offset.js b/src/components/controls-shape-offset.js
index 7ce876433..7f47c498b 100644
--- a/src/components/controls-shape-offset.js
+++ b/src/components/controls-shape-offset.js
@@ -2,7 +2,7 @@ import { CONTROLLER_OFFSETS } from "./hand-controls2.js";
AFRAME.registerComponent("controls-shape-offset", {
schema: {
- additionalOffset: { default: { x: 0, y: -0.03, z: -0.04 } }
+ additionalOffset: { type: "vec3", default: { x: 0, y: -0.03, z: -0.04 } }
},
init: function() {
this.controller = null;
diff --git a/src/components/hand-controls2.js b/src/components/hand-controls2.js
index a5f212453..e8aca3e7c 100644
--- a/src/components/hand-controls2.js
+++ b/src/components/hand-controls2.js
@@ -109,8 +109,7 @@ AFRAME.registerComponent("hand-controls2", {
const controlConfiguration = {
hand: hand,
- model: false,
- rotationOffset: 0
+ model: false
};
if (hand !== prevData) {
diff --git a/src/components/hide-when-quality.js b/src/components/hide-when-quality.js
index e09d3ae90..93e238d61 100644
--- a/src/components/hide-when-quality.js
+++ b/src/components/hide-when-quality.js
@@ -17,7 +17,6 @@ AFRAME.registerComponent("hide-when-quality", {
},
updateComponentState(quality) {
- console.log(quality);
this.el.setAttribute("visible", quality !== this.data);
}
});
diff --git a/src/react-components/avatar-selector.js b/src/react-components/avatar-selector.js
index 4495819a8..e4b27897e 100644
--- a/src/react-components/avatar-selector.js
+++ b/src/react-components/avatar-selector.js
@@ -131,7 +131,7 @@ class AvatarSelector extends Component {
<a-entity key={avatar.id} rotation={`0 ${360 * -i / this.props.avatars.length} 0`}>
<a-entity position="0 0 5" gltf-model-plus={`src: #${avatar.id}`} inflate="true">
<template data-selector=".RootScene">
- <a-entity animation-mixer />
+ <a-entity animation-mixer="" />
</template>
<a-animation
@@ -168,7 +168,7 @@ class AvatarSelector extends Component {
</a-entity>
<a-entity position="0 1.5 -5.6" rotation="-10 180 0">
- <a-entity camera />
+ <a-entity camera="" />
</a-entity>
<a-entity
--
GitLab