From 5e60dc5993688df51ad25d8e874ae6fed8e2efdf Mon Sep 17 00:00:00 2001
From: netpro2k <netpro2k@gmail.com>
Date: Thu, 5 Apr 2018 19:49:23 -0700
Subject: [PATCH] Add note about audio-feedback hack
---
src/components/audio-feedback.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/components/audio-feedback.js b/src/components/audio-feedback.js
index 6e6ea7813..d4bdf5792 100644
--- a/src/components/audio-feedback.js
+++ b/src/components/audio-feedback.js
@@ -77,6 +77,8 @@ AFRAME.registerComponent("scale-audio-feedback", {
},
onAudioFrequencyChange(e) {
+ // TODO: come up with a cleaner way to handle this.
+ // bone's are "hidden" by scaling them with bone-visibility, without this we would overwrite that.
if (!this.el.object3D.visible) return;
const { minScale, maxScale } = this.data;
this.el.object3D.scale.setScalar(minScale + (maxScale - minScale) * e.detail.volume / 255);
--
GitLab