From 65dde88905f8f2f3add9b8712523ab3fe9fc6584 Mon Sep 17 00:00:00 2001
From: Brian Peiris <brianpeiris@gmail.com>
Date: Thu, 29 Mar 2018 22:31:18 -0700
Subject: [PATCH] improve linting and add travis config
---
.eslintignore | 2 ++
.eslintrc.js | 22 ++++++++++++++++++++++
.eslintrc.json | 16 ----------------
.travis.yml | 3 +++
package.json | 3 ++-
5 files changed, 29 insertions(+), 17 deletions(-)
create mode 100644 .eslintignore
create mode 100644 .eslintrc.js
delete mode 100644 .eslintrc.json
create mode 100644 .travis.yml
diff --git a/.eslintignore b/.eslintignore
new file mode 100644
index 000000000..70fa045e8
--- /dev/null
+++ b/.eslintignore
@@ -0,0 +1,2 @@
+!.eslintrc.js
+src/vendor/*
diff --git a/.eslintrc.js b/.eslintrc.js
new file mode 100644
index 000000000..730839944
--- /dev/null
+++ b/.eslintrc.js
@@ -0,0 +1,22 @@
+module.exports = {
+ parser: "babel-eslint",
+ env: {
+ browser: true,
+ es6: true,
+ node: true
+ },
+ globals: {
+ THREE: true,
+ AFRAME: true,
+ NAF: true
+ },
+ plugins: ["prettier", "react"],
+ rules: {
+ "prettier/prettier": "error",
+ "prefer-const": "error",
+ "no-var": "error",
+ // Light console usage is useful but remove debug logs before merging to master.
+ "no-console": "off"
+ },
+ extends: ["prettier", "plugin:react/recommended", "eslint:recommended"]
+};
diff --git a/.eslintrc.json b/.eslintrc.json
deleted file mode 100644
index 8ab63d8cc..000000000
--- a/.eslintrc.json
+++ /dev/null
@@ -1,16 +0,0 @@
-{
- "parser": "babel-eslint",
- "plugins": [
- "prettier",
- "react"
- ],
- "rules": {
- "prettier/prettier": "error",
- "prefer-const": "error",
- "no-var": "error"
- },
- "extends": [
- "prettier",
- "plugin:react/recommended"
- ]
-}
diff --git a/.travis.yml b/.travis.yml
new file mode 100644
index 000000000..d6dbc895d
--- /dev/null
+++ b/.travis.yml
@@ -0,0 +1,3 @@
+language: node_js
+install: yarn
+script: yarn lint
diff --git a/package.json b/package.json
index cb743e54e..6553a30e9 100644
--- a/package.json
+++ b/package.json
@@ -11,7 +11,8 @@
"postinstall": "node ./scripts/postinstall.js",
"start": "cross-env NODE_ENV=development webpack-dev-server",
"build": "rimraf ./public && cross-env NODE_ENV=production webpack --mode=production",
- "prettier": "prettier --write src/**/*.js"
+ "prettier": "prettier --write src/**/*.js",
+ "lint": "eslint *.js src/**/*.js"
},
"dependencies": {
"aframe-billboard-component": "^1.0.0",
--
GitLab