From 6ee1c6462af688ac865ac6a309a1df3f4f2f216d Mon Sep 17 00:00:00 2001
From: Greg Fodor <gfodor@gmail.com>
Date: Tue, 6 Mar 2018 13:20:48 -0800
Subject: [PATCH] Fix variable bindings for inner loops which led to infinite
loop
---
src/elements/a-gltf-entity.js | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/elements/a-gltf-entity.js b/src/elements/a-gltf-entity.js
index afc9522ad..005713f93 100644
--- a/src/elements/a-gltf-entity.js
+++ b/src/elements/a-gltf-entity.js
@@ -95,17 +95,17 @@ function attachTemplate(templateEl) {
const templateRoot = clone.firstElementChild;
const templateRootAttrs = templateRoot.attributes;
- for (var i = 0; i < targetEls.length; i++) {
+ for (let i = 0; i < targetEls.length; i++) {
const targetEl = targetEls[i];
// Merge root element attributes with the target element
- for (var i = 0; i < templateRootAttrs.length; i++) {
- targetEl.setAttribute(templateRootAttrs[i].name, templateRootAttrs[i].value);
+ for (let j = 0; j < templateRootAttrs.length; j++) {
+ targetEl.setAttribute(templateRootAttrs[j].name, templateRootAttrs[j].value);
}
// Append all child elements
- for (var i = 0; i < templateRoot.children.length; i++) {
- targetEl.appendChild(document.importNode(templateRoot.children[i], true));
+ for (let j = 0; j < templateRoot.children.length; j++) {
+ targetEl.appendChild(document.importNode(templateRoot.children[j], true));
}
}
}
--
GitLab