From 89295f7962aa206a473273ef449965b4b1b4900a Mon Sep 17 00:00:00 2001
From: Robert Long <robert@robertlong.me>
Date: Tue, 31 Oct 2017 16:03:54 -0700
Subject: [PATCH] Upgrade naf-janus-adapter. Fix undefined media stream.
---
package.json | 2 +-
src/components/audio-feedback.js | 5 ++++-
yarn.lock | 6 +++---
3 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/package.json b/package.json
index d3f49ce1c..293a1ad4c 100644
--- a/package.json
+++ b/package.json
@@ -14,7 +14,7 @@
"dependencies": {
"aframe-input-mapping-component": "https://github.com/fernandojsg/aframe-input-mapping-component",
"aframe-teleport-controls": "https://github.com/netpro2k/aframe-teleport-controls#feature/teleport-origin",
- "naf-janus-adapter": "^0.1.3",
+ "naf-janus-adapter": "^0.1.4",
"networked-aframe": "https://github.com/netpro2k/networked-aframe#feature/register-adapter",
"pleasejs": "^0.4.2",
"query-string": "^5.0.1"
diff --git a/src/components/audio-feedback.js b/src/components/audio-feedback.js
index ee4b802be..2b24abd94 100644
--- a/src/components/audio-feedback.js
+++ b/src/components/audio-feedback.js
@@ -22,12 +22,15 @@ AFRAME.registerComponent("networked-audio-analyser", {
return NAF.connection.adapter.getMediaStream(ownerId);
})
.then(stream => {
+ if (!stream) {
+ return;
+ }
+
const ctx = THREE.AudioContext.getContext();
const source = ctx.createMediaStreamSource(stream);
this.analyser = ctx.createAnalyser();
this.levels = new Uint8Array(this.analyser.frequencyBinCount);
source.connect(this.analyser);
- console.log(source, this.analyser);
});
},
diff --git a/yarn.lock b/yarn.lock
index 17ec74b58..bf1721606 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -2732,9 +2732,9 @@ multicast-dns@^6.0.1:
dns-packet "^1.0.1"
thunky "^0.1.0"
-naf-janus-adapter@^0.1.3:
- version "0.1.3"
- resolved "https://registry.yarnpkg.com/naf-janus-adapter/-/naf-janus-adapter-0.1.3.tgz#575979e964a5f8ef712f9746e5b59dfd989bb31f"
+naf-janus-adapter@^0.1.4:
+ version "0.1.4"
+ resolved "https://registry.yarnpkg.com/naf-janus-adapter/-/naf-janus-adapter-0.1.4.tgz#3e6e2022e8f6d5b7f6221fcec8b36a1e1e13be44"
dependencies:
minijanus "^0.1.4"
--
GitLab