From bc85ab416ecb32ccba181839c33133df5ea2ad57 Mon Sep 17 00:00:00 2001
From: johnshaughnessy <johnfshaughnessy@gmail.com>
Date: Mon, 6 Aug 2018 17:19:49 -0700
Subject: [PATCH] Simplify setting of attributionImage state
---
src/react-components/create-object-dialog.js | 14 ++++----------
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/src/react-components/create-object-dialog.js b/src/react-components/create-object-dialog.js
index 364bd46b2..6e7707e00 100644
--- a/src/react-components/create-object-dialog.js
+++ b/src/react-components/create-object-dialog.js
@@ -48,19 +48,13 @@ export default class CreateObjectDialog extends Component {
}
onUrlChange = e => {
- let url;
- try {
- url = new URL(e.target.value);
- } catch (_) {
- this.setState({
- url: e.target && e.target.value
- // Not a valid URL, so don't try to set attributeImage using url.hostname
- });
- return;
+ let attributionImage = this.state.attributionImage;
+ if (e.target && e.target.value && e.target.validity.valid){
+ attributionImage = attributionHostnames[new URL(e.target.value).hostname];
}
this.setState({
url: e.target && e.target.value,
- attributionImage: e.target && e.target.value && e.target.validity.valid && attributionHostnames[url.hostname]
+ attributionImage: attributionImage
});
};
--
GitLab