From e88021f6a3f9f38eef958ded2aa5a12031d8fbfe Mon Sep 17 00:00:00 2001
From: Robert Long <robert@robertlong.me>
Date: Tue, 7 Aug 2018 16:24:01 -0700
Subject: [PATCH] Tweak lights
---
src/components/directional-light.js | 1 +
src/components/hemisphere-light.js | 2 +-
src/components/spot-light.js | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/components/directional-light.js b/src/components/directional-light.js
index 7db6bc2cd..cd501d710 100644
--- a/src/components/directional-light.js
+++ b/src/components/directional-light.js
@@ -9,6 +9,7 @@ AFRAME.registerComponent("directional-light", {
const el = this.el;
this.light = new THREE.DirectionalLight();
this.light.target.position.set(0, 0, 1);
+ this.light.add(this.light.target);
this.el.setObject3D("directional-light", this.light);
this.el.sceneEl.systems.light.registerLight(el);
},
diff --git a/src/components/hemisphere-light.js b/src/components/hemisphere-light.js
index 43e2d730a..ec26e4c16 100644
--- a/src/components/hemisphere-light.js
+++ b/src/components/hemisphere-light.js
@@ -14,7 +14,7 @@ AFRAME.registerComponent("hemisphere-light", {
update(prevData) {
if (this.data.skyColor !== prevData.skyColor) {
- this.light.skyColor.set(this.data.skyColor);
+ this.light.color.set(this.data.skyColor);
}
if (this.data.groundColor !== prevData.groundColor) {
diff --git a/src/components/spot-light.js b/src/components/spot-light.js
index 930ff89b5..bcfd65dae 100644
--- a/src/components/spot-light.js
+++ b/src/components/spot-light.js
@@ -12,6 +12,7 @@ AFRAME.registerComponent("spot-light", {
const el = this.el;
this.light = new THREE.SpotLight();
this.light.target.position.set(0, 0, 1);
+ this.light.add(this.light.target);
this.light.decay = 2;
this.el.setObject3D("spot-light", this.light);
this.el.sceneEl.systems.light.registerLight(el);
--
GitLab