From ea383606d41b47810dcd0b15c39aa5805d318b59 Mon Sep 17 00:00:00 2001 From: netpro2k <netpro2k@gmail.com> Date: Wed, 14 Mar 2018 17:59:02 -0700 Subject: [PATCH] Fix cloning of GLTFs with unnamed bones --- src/elements/a-gltf-entity.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src/elements/a-gltf-entity.js b/src/elements/a-gltf-entity.js index 3c9c07031..6c4490d23 100644 --- a/src/elements/a-gltf-entity.js +++ b/src/elements/a-gltf-entity.js @@ -22,19 +22,21 @@ AFRAME.AGLTFEntity = { // From https://gist.github.com/cdata/f2d7a6ccdec071839bc1954c32595e87 // Tracking glTF cloning here: https://github.com/mrdoob/three.js/issues/11573 function cloneGltf(gltf) { - const clone = { - animations: gltf.animations, - scene: gltf.scene.clone(true) - }; - const skinnedMeshes = {}; - gltf.scene.traverse(node => { + if (!node.name) { + node.name = node.uuid; + } if (node.isSkinnedMesh) { skinnedMeshes[node.name] = node; } }); + const clone = { + animations: gltf.animations, + scene: gltf.scene.clone(true) + }; + const cloneBones = {}; const cloneSkinnedMeshes = {}; -- GitLab