Skip to content

Add QKeras as a package dependency

Javier Duarte requested to merge github/fork/vloncar/qkeras_dep into master

Created by: vloncar

So far we have avoided requiring QKeras installation and tried to only load it if available. The reasons for this are long gone now, and much of the advanced functionality is not available without QKeras, so we should make it a hard dependency. Since it will be installed by pip alongside hls4ml, the impact on users should be minimal. As for "why now?", well, GitHub changed the checkout policy for unauthenticated git access which broke Jenkins tests. While the fix for that particular issue is trivial it reveals that the current code-base simply doesn't work without QKeras, so instead of maintaining this feature of QKeras being optional, we should make sure it is installed in the first place.

Merge request reports

Loading