Skip to content

For encoded convolution, add check for when min_width would have been larger than in_width

Javier Duarte requested to merge github/fork/jmitrevs/encoded_small_width into main

Created by: jmitrevs

Description

In the encoded convolution, the case when the in_width is smaller than the nominal min_width needs to be handled as a special case. This attempts to fix this situation. It has been been minimally tested in a conv1d case where in_width = 11 while the kernel width is 9. Additional tests need to be made.

Type of change

For a new feature or function, please create an issue first to discuss it with us before submitting a pull request.

Note: Please delete options that are not relevant.

  • Bug fix (non-breaking change that fixes an issue)

Tests

test_conv1d_narrow.py fails in main, but passes after this fix. Similarly with test_conv2d_narrow.py.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.

Merge request reports