Skip to content

Edit order of the optimizers in the flow so that BramFactor is followed

Javier Duarte requested to merge jmitrevs/bram-order into main

Created by: jmitrevs

Description

The order of the optimizers made register_bram_weights do nothing. Moving it after transform_types seems to fix the problem. Also added a simple pytest to make sure that BramFactor is not ignored.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

Added test_bram_factor.py, which copies test_dense from test_keras_api.py but with BramFactor set to 0. A check is added to make sure that some variables have storage == 'bram'.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.

Merge request reports