Skip to content

Fix RNN layers when strategy=resource

Javier Duarte requested to merge github/fork/vloncar/rnn_fixes into main

Created by: vloncar

Description

The RNN layers erroneously transposed layers during initialization in the backend, despite this functionality being moved into a separate pass. I also cleaned up the code a bit to align it more with the rest of the codebase. It fixes #779 (closed).

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

The existing test_rnn_accuracy has been extended to include strategy to verify the behavior is correct.

Test Configuration:

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

Merge request reports

Loading