Skip to content

Explicitly set strategy for pointwise conv

Javier Duarte requested to merge github/fork/vloncar/config_case into main

Created by: vloncar

Description

When optimizing 1x1 convolution a new node will be inserted with the same name and the user config will be used. This means the new PointwiseConv1D/2D node will pick up whatever string the user set in the config and unless that matches lowercase latency or resource the compilation will fail. This was observed in #782.

The solution is not elegant, but it was the least intrusive. It should be fine until we rework the config itself.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

The test_pointwiseconv.py was extended to incude a test for this scenario.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

Merge request reports