Skip to content

Add support for filt_height==1 for streaming quartus conv2d

Javier Duarte requested to merge github/fork/jmitrevs/pointwise_tolerate_quartus into main

Created by: jmitrevs

Description

The streaming Conv2D implementation in the quartus backend doesn't handle the filt_height==1 case, as discovered in #878 and #855. We currently do not have a special pointwise streaming implementation for quartus, but nevertheless the default implementation should be able to handle the case, even if a bit less efficiently. This PR adds some C++ fixes for issues that clang and i++ complained about (but not g++).

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

I just enabled streaming with the Quartus backend to the test_pointwiseconv.py test. As mentioned, there is no special pointwise implementation in this case, but the results should nevertheless be correct

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

Merge request reports