Skip to content

Remove #INLINE pragma to fix SeparableConv1D with Vitis backed

Javier Duarte requested to merge github/fork/qberthet/fix_897 into main

Created by: qberthet

Fixes #897

Description

With Vitis backend, when #pragma HLS function_instantiate is used, #pragma HLS INLINE can only be used with the off option to forbid inlining. Using only #pragma HLS INLINE results in the error mentionned in #897.

From what I understand from https://docs.xilinx.com/r/2022.2-English/ug1399-vitis-hls/Function-Instantiation, removing this pragma does not means that inlining will not be performed when possible.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

As this is tested during CSynth, no PyTest are provided, but the test script in #897 can be used to test that the problem is indeed fixed.

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.

Merge request reports