Skip to content

[DRAFT] Fix pooling accum_t autoset & avoid global override

Javier Duarte requested to merge github/fork/calad0i/pool_accum_t_autoset_fix into main

Created by: calad0i

A# Description

No test at the moment - Fix a series of strange accum_t behaviors for pooling layers in the current version. Potential conflict with #855, would need to converge first before finalizing changes.

Strange behaviors:

  • model_default precision overridden
  • Extra integer bits were added, while the number of fp bits decreased

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Tests

Not yet available.

Test Configuration:

Checklist

  • I have read the guidelines for contributing.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have installed and run pre-commit on the files I edited or added.
  • I have added tests that prove my fix is effective or that my feature works.

Merge request reports