Skip to content
Snippets Groups Projects
  1. Jul 19, 2018
    • Mark Mandel's avatar
      Missing `watch` permission in rbac for agones-sdk · 9dc9109b
      Mark Mandel authored
      Getting the following error in the logs.
      `{"level":"error","msg":"agones.dev/agones/pkg/client/informers/externalversions/factory.go:74: Failed to watch *v1alpha1.GameServer: unknown (get gameservers.stable.agones.dev)","time":"2018-07-19T21:52:23Z"}`
      
      Needed the `watch` permission to make it go away.
      
      We aren't watching for events right now, so it's just noise,
      but it's better with it gone.
      9dc9109b
  2. Jul 18, 2018
  3. Jul 17, 2018
  4. Jul 16, 2018
  5. Jul 11, 2018
    • Borislav Kosharov's avatar
      fix yaml install link · f85fa1af
      Borislav Kosharov authored
      f85fa1af
    • Mark Mandel's avatar
      [Breaking Change] Multiple port support for `GameServer` · 180c6c94
      Mark Mandel authored
      This allows the `GameServer` (and anything that uses it as a template,  such
      as `Fleets`), to provide configuration and assignment of multiple ports to the
      game server container.
      
      For example:
      
      ```yaml
      apiVersion: "stable.agones.dev/v1alpha1"
      kind: GameServer
      metadata:
        name: "simple-udp"
      spec:
        ports:
        - name: default
          portPolicy: "dynamic"
          containerPort: 7654
        template:
          spec:
            containers:
            - name: simple-udp
              image: gcr.io/agones-images/udp-server:0.1
      ```
      
      This also includes update to documentation - but in a separate bottom section
      of each document, to allow for moving into the live version at release time.
      (This is becoming a mess - a website can't come soon enough).
      
      This also adjusts the `GameServer > Status`, to be able to handle multiple
      ports. It now looks like this:
      
      ```
      Status:
        Address:    192.168.99.100
        Node Name:  agones
        Ports:
          Name:  default
          Port:  7502
        State:   Ready
      ```
      
      While this a breaking change (due to the change in `GameServer > status`, the
      previous legacy configuration of still works (even thought it's no longer
      documented), as it is automatically converted to the new version.
      
      Plans are to remove this legacy conversion functionality in 0.4.0, since being
      in alpha, we have a very low commitment to backward compatibility.
      
      As an aside - versioning for CRDs is coming soon, so this will also solve this
      type of problem long term.
      180c6c94
    • Cyril TOVENA's avatar
  6. Jul 09, 2018
    • Mark Mandel's avatar
      Fix bug with hung GameServer resource on Kubernetes 1.10 · d3e9d7ee
      Mark Mandel authored
      It looks like the `foregroundDeletion` finalizer that gets added to the
      GameServer when a deletion with foreground propogation is requested -
      when it gets removed, by the Kubernetes system, the ResourceVersion/Generation
      doesn't get incremented.
      
      This means when we do an `Update` it will go through (usually it fails if the
      ResourceVersion/Generation has changed since the last update), rather than
      failing and going back to re-sync.
      
      This can cause a race condition where the `Update` can basically put back
      the `foregroundDeletion` finalizer, if it gets removed between retrieving the
      `GameServer` object and doing the `Update()` operation.
      
      We actually don't need the `foregroundDeletion` propogation on `Delete()`, as
      we only want to keep the `GameServer` around until the backing `Pod` is gone,
      so we can actually just turn this off instead in the code.
      
      As a note - also explored using a `Patch()` operation to try and solve this
      problem. AFAIK, a patch (and specifically a JSONPatch - other patch types
      didn't seem better), can only do index based removal from a list of items.
      
      This could just present other types of race conditions, as finalizers could
      be added/removed by other systems at the same time as well, changing the index
      to the finalizer we want at the same time.
      
      Not sure if this is a bug in the Kubernetes system, or working as intended,
      but this solves the issue.
      d3e9d7ee
  7. Jul 04, 2018
  8. Jul 03, 2018
  9. Jun 25, 2018
  10. Jun 21, 2018
    • Mark Mandel's avatar
      Remove line · e6cdac05
      Mark Mandel authored
      Found a line here that makes no sense.
      e6cdac05
    • Mark Mandel's avatar
      Update minikube instructions to 0.28.0 · 68d83080
      Mark Mandel authored
      Have working instructions for running Kubernetes 1.10 on top of
      minikube 0.28.0 - including a workaround for non default profiles.
      
      Since Agones works fine on k8s 1.10, figured it was worth making the move.
      68d83080
  11. Jun 19, 2018
  12. Jun 18, 2018
  13. Jun 17, 2018
  14. Jun 14, 2018
  15. Jun 13, 2018
  16. Jun 12, 2018
  17. Jun 09, 2018
  18. Jun 08, 2018
  19. Jun 06, 2018
    • Mark Mandel's avatar
      Make Cloud Builder Faster · d9786bf6
      Mark Mandel authored
      This should make Cloud Builder faster
      - Request an 8 core machine
      - Move the test and build steps to be parralel.
      d9786bf6
    • Mark Mandel's avatar
      Lock protoc-gen-go to 1.0 release · bafd6423
      Mark Mandel authored
      Noticed that this library wasn't locked to a version,
      so when I attempt to regen the code, I got some incompatible
      code.
      
      This fixes things.
      bafd6423
Loading