Properly set npm debug log filter

2ecc5fdd · Greg Fodor · 14de33c5 · 2ecc5fdd · 2ecc5fdd · 2ecc5fdd
Commit 2ecc5fdd authored 6 years ago by Greg Fodor
--- a/src/hub.html
+++ b/src/hub.html
@@ -10,9 +10,6 @@
    <link rel="shortcut icon" type="image/png" href="/favicon.ico">
    <title>Get together | Hubs by Mozilla</title>
    <link href="https://fonts.googleapis.com/css?family=Zilla+Slab:300,300i,400,400i,700" rel="stylesheet">
-    <!-- HACK: this has to run after A-Frame but before our bundle, since A-Frame blows away the local storage setting -->
-    <script src="https://cdn.rawgit.com/gfodor/ba8f88d9f34fe9cbe59a01ce3c48420d/raw/03e31f0ef7b9eac5e947bd39e440f34df0701f75/naf-janus-adapter-logging.js" integrity="sha384-4q1V8Q88oeCFriFefFo5uEUtMzbw6K116tFyC9cwbiPr6wEe7050l5HoJUxMvnzj" crossorigin="anonymous"></script>
 </head>
 <body>

--- a/src/hub.js
+++ b/src/hub.js
@@ -3,6 +3,7 @@ console.log(`Hubs version: ${process.env.BUILD_VERSION || "?"}`);
 import "./assets/stylesheets/hub.scss";
 import "aframe";
+import "./utils/logging";
 import { patchWebGLRenderingContext } from "./utils/webgl";
 patchWebGLRenderingContext();

--- a/src/utils/logging.js
+++ b/src/utils/logging.js
+// A-Frame blows away any npm debug log filters so this allow the user to set the log filter
+// via the query string.
+import debug from "debug";
+const qs = new URLSearchParams(location.search);
+function qsTruthy(param) {
+  const val = qs.get(param);
+  // if the param exists but is not set (e.g. "?foo&bar"), its value is the empty string.
+  return val === "" || /1|on|true/i.test(val);
+}
+const isDebug = qsTruthy("debug");
+const logFilter = qs.get("log_filter") || (isDebug && "naf-janus-adapter:*");
+if (logFilter) {
+  debug.enable(logFilter);
+}